PMD Results

The following document contains the results of PMD 4.2.2.

Files

entagged/audioformats/AudioFile.java

Violation Line
Avoid unused imports such as 'entagged.audioformats.exceptions.CannotWriteException' 23

entagged/audioformats/EncodingInfo.java

Violation Line
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 102
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 264

entagged/audioformats/asf/data/ExtendedContentDescription.java

Violation Line
Avoid empty catch blocks 224 - 226

entagged/audioformats/asf/data/GUID.java

Violation Line
These nested if statements could be combined 154 - 156
Ensure you override both equals() and hashCode() 229

entagged/audioformats/asf/io/ContentDescriptionReader.java

Violation Line
These nested if statements could be combined 90 - 94

entagged/audioformats/asf/util/Utils.java

Violation Line
These nested if statements could be combined 267 - 271

entagged/audioformats/exceptions/ModifyVetoException.java

Violation Line
Avoid unused imports such as 'java.io.File' 21

entagged/audioformats/mp3/util/Id3v2TagCreator.java

Violation Line
Avoid empty if statements 81 - 85

entagged/audioformats/mp3/util/id3frames/Id3Frame.java

Violation Line
Ensure you override both equals() and hashCode() 152

hotsax/html/sax/DebugParserDelegate.java

Violation Line
Avoid unused private fields such as 'reader'. 20
Avoid unused constructor parameters such as 'HtmlParser'. 27 - 30

hotsax/html/sax/HtmlLexer.java

Violation Line
Avoid unused imports such as 'java.util.StringTokenizer' 7
Avoid unused private fields such as 'YY_ILLEGAL_STATE'. 105
Avoid unused private fields such as 'yyline'. 157
Avoid unused private fields such as 'yychar'. 160
Avoid unused private fields such as 'yycolumn'. 166
Avoid unused private fields such as 'yy_atBOL'. 171
Avoid unused private fields such as 'text'. 182
Avoid unused private fields such as 'attr'. 183
Avoid unused private fields such as 'comment'. 184
Avoid unused private fields such as 'pi'. 185
Avoid unused private fields such as 'cdata'. 186
Avoid unused private fields such as 'script'. 187
Avoid unused private fields such as 'doctype'. 188
Avoid unused private fields such as 'first'. 206
Avoid unused private fields such as 'last'. 207

hotsax/html/sax/HtmlParser.java

Violation Line
Avoid unused private fields such as 'savedLexer'. 360

hotsax/html/sax/SaxHandlerDelegate.java

Violation Line
Avoid unused private fields such as 'reader'. 20
Avoid unused constructor parameters such as 'HtmlParser'. 27 - 30

hotsax/html/sax/SaxParser.java

Violation Line
Avoid unused private fields such as 'lexer'. 41
Avoid unused private fields such as 'reader'. 44
Avoid instantiating Boolean objects; reference Boolean.TRUE or Boolean.FALSE or call Boolean.valueOf() instead. 105
Avoid empty catch blocks 188 - 190

hotsax/html/sax/ScriptLexer.java

Violation Line
Avoid unused private fields such as 'YY_ILLEGAL_STATE'. 83
Avoid unused private fields such as 'yyline'. 133
Avoid unused private fields such as 'yychar'. 136
Avoid unused private fields such as 'yycolumn'. 142
Avoid unused private fields such as 'yy_atBOL'. 147
Avoid unused private fields such as 'first'. 186
Avoid unused private fields such as 'last'. 187

hotsax/html/sax/StyleLexer.java

Violation Line
Avoid unused private fields such as 'YY_ILLEGAL_STATE'. 82
Avoid unused private fields such as 'yyline'. 132
Avoid unused private fields such as 'yychar'. 135
Avoid unused private fields such as 'yycolumn'. 141
Avoid unused private fields such as 'yy_atBOL'. 146
Avoid unused private fields such as 'first'. 185
Avoid unused private fields such as 'last'. 186

sk/baka/ambient/PlaybackNotificator.java

Violation Line
These nested if statements could be combined 97 - 106

sk/baka/ambient/PlaylistPlayer.java

Violation Line
Avoid empty if statements 467 - 469

sk/baka/ambient/activity/ConfigActivity.java

Violation Line
Unnecessary final modifier in final class 57 - 65

sk/baka/ambient/activity/main/PlayerController.java

Violation Line
Avoid unnecessary return statements 344

sk/baka/ambient/activity/search/LibraryEngine.java

Violation Line
This for loop could be simplified to a while loop 69 - 71

sk/baka/ambient/activity/search/MagnatuneEngine.java

Violation Line
This for loop could be simplified to a while loop 70 - 72

sk/baka/ambient/collection/CollectionSynchronizer.java

Violation Line
These nested if statements could be combined 228 - 231

sk/baka/ambient/collection/TrackMetadataBean.java

Violation Line
Unnecessary final modifier in final class 123 - 137

sk/baka/ambient/collection/ampache/AmpacheClient.java

Violation Line
These nested if statements could be combined 404 - 407
These nested if statements could be combined 522 - 525
These nested if statements could be combined 676 - 679

sk/baka/ambient/collection/ampache/CollectionImpl.java

Violation Line
Avoid unused imports such as 'java.util.concurrent.CopyOnWriteArrayList' 26

sk/baka/ambient/collection/local/AbstractTrackProvider.java

Violation Line
These nested if statements could be combined 91 - 98

sk/baka/ambient/collection/local/MediaStoreCollection.java

Violation Line
These nested if statements could be combined 110 - 112

sk/baka/ambient/commons/SocketServer.java

Violation Line
Avoid empty catch blocks 184 - 186

sk/baka/ambient/commons/TagFormatter.java

Violation Line
This for loop could be simplified to a while loop 137 - 155
Unnecessary final modifier in final class 406 - 413

sk/baka/ambient/library/DBStrategy.java

Violation Line
Unnecessary final modifier in final class 386 - 388
Avoid unused private methods such as 'getTableName(CategoryEnum)'. 386

sk/baka/ambient/library/Library.java

Violation Line
This for loop could be simplified to a while loop 75 - 77

sk/baka/ambient/playerservice/IPlayer.java

Violation Line
Avoid importing anything from the package 'java.lang' 6
Avoid unused imports such as 'java.lang.String' 6
Avoid unused imports such as 'android.os.RemoteException' 7
Avoid unused imports such as 'android.os.IInterface' 9
Avoid unused imports such as 'android.os.Binder' 10
Avoid unused imports such as 'android.os.Parcel' 11

sk/baka/ambient/playerservice/PlayerService.java

Violation Line
Avoid empty catch blocks 84 - 87
Unnecessary final modifier in final class 248 - 250

sk/baka/ambient/playlist/Parsers.java

Violation Line
Avoid empty catch blocks 220 - 222
Avoid empty catch blocks 348 - 350

sk/baka/ambient/views/ButtonBar.java

Violation Line
Unnecessary final modifier in final class 129 - 144

sk/baka/ambient/views/ViewUtils.java

Violation Line
Unnecessary final modifier in final class 57 - 59

sk/baka/ambient/views/gesturelist/KeypadController.java

Violation Line
These nested if statements could be combined 142 - 147

sk/baka/ambient/views/gesturelist/MutableListAdapter.java

Violation Line
Unnecessary final modifier in final class 77 - 86